Commit messages should be wrapped at 80 72 columns.
Note that for trivial commits, such as fixes for spelling mistakes, the verbose description may not be necessary.
If you do not reference an issue when you submit a review the review tool will remind you that you should. While it is not currently required to include an issue in the commit message it is highly preferred.
To have a commit noted in an issue and to also close the issue, simply referencing the issue is sufficient:
If the patch being committed was written by the person doing the commit , and is not available to reference as an upload to the issue , there is is no need to include something like "fixed by me" , as that will be the default assumption when a specific patch is not referenced.
core/db: Fix DBDelTree error codes for AMI, CLI and AGI. The AMI DBDelTree command will return Success/Key tree deleted successfully even if the given key does not exist. The CLI command 'database deltree' had a similar problem, but was saved because it actually responded with '0 database entries removed'. AGI had a slightly different error, where it would return success if the database was unavailable. This came from confusion about the ast_db_deltree retval, which is -1 in the event of a database error, or number of entries deleted (including 0 for deleting nothing). * Changed some poorly named res variables to num_deleted * Specified specific errors when calling ast_db_deltree (database unavailable unavailable vs. entry not found vs. success) * Fixed similar bug in AGI database deltree, where 'Database unavailable' results in successful result ASTERISK-967 Reported by: John Bigelow Tested by: John Bigelow