Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • -2 should only be used if the current implementation requires a complete rewrite to be acceptable, or if the change should not be made under any implementation.

    Note

    If you use a -2, please be prepared to justify its usage.

  • +2 should generally not be given unless someone has already given the review a +1.
  • Users Related to the previous, users who provide a +2 should generally not provide it to a change that they provided the +1 on.
  • Please read the Asterisk project Coding Guidelines prior to submitting patches. When performing code reviews, please refer to the Code Review Checklist.

...