Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 11 Next »

Icon

This page is in draft status.

Overview

This page documents:

  • Asterisk's various Git repositories, and their intended purposes.
  • Policies for using Git and Gerrit with Asterisk.

Git Repositories

Gerrit: https://gerrit.asterisk.org

Asterisk uses Gerrit as its primary repository and for for code review. Users who are looking to clone or contribute patches back to Asterisk should work the repositories on Gerrit. Please see the Gerrit Usage documentation for more information.

Gitolite: https://git.asterisk.org

The repositories on https://git.asterisk.org mirror the repositories on Gerrit, and provide source tree browsing.

GitHub: https://github.com/asterisk

The repositories on GitHub mirror the repositories on Gerrit, also provide source tree browsing, and exist because of GitHub's popularity.

Pull requests on GitHub WILL be ignored.

On this Page

Gerrit Access

Anyone may clone repositories from Gerrit anonymously.

Users may participate in code reviews or contribute patches if they have signed a Contributor License Agreement. Access to Gerrit is performed using your JIRA (Atlassian) username/password. You may create an account at https://signup.asterisk.org, and sign a CLA in JIRA. Note that you will not be able to log into Gerrit if a CLA is not associated with your JIRA account.

Icon

When submitting a patch to Gerrit, you are explicitly doing so under the terms and conditions of the Contributor License Agreement. If you do not wish to contribute a patch back to the Asterisk project, please do not push a patch up to Gerrit.

Gerrit Policies

Code Reviews

  • -2 should only be used if the current implementation requires a complete rewrite to be acceptable, or if the change should not be made under any implementation.

    Icon

    If you use a -2, please be prepared to justify its usage.

  • +2 should not be given unless someone has already given the review a +1.
  • Users who provide a +2 should not provide it to a change that they provided the +1 on.
  • Please read the Asterisk project Coding Guidelines prior to submitting patches. When performing code reviews, please refer to the Code Review Checklist.

Topics

  • Please use the -t option with git review, specifying the ASTERISK issue the change should be associated with:

    This helps to tie Gerrit reviews to the JIRA issue that necessitated the change.

Cherry-Picking

  • All branches that require the change should have the change cherry-picked to that branch, and submitted for review. See Software Configuration Management Policies for which patch types are appropriate for what branches. See Gerrit Usage for instructions on cherry-picking.
  • The same Gerrit Change Id must be present in all cherry-picked commits.
  • The same topic (ASTERISK issue) must be used in all reviews.
  • Test Suite test reviews should use the same topic (ASTERISK issue) as the code change reviews.

 

  • No labels